Add default 3d view preferences for #742#836
Open
frmdstryr wants to merge 3 commits intohorizon-eda:masterfrom
Open
Add default 3d view preferences for #742#836frmdstryr wants to merge 3 commits intohorizon-eda:masterfrom
frmdstryr wants to merge 3 commits intohorizon-eda:masterfrom
Conversation
Member
|
How does this interact with the solder mask, silkscreen and substrate colors stored in the board? |
Contributor
Author
|
Guess I somehow missed that boards store their own colors (was only looking at canvas3d and didn't see the usage in imp_board until your comment). The only way I can see it working with both the global preferences and the BoardColors is if the BoardColors are made optional to tell it to fall back to the preferences or not. Should I try that (or something) or just remove the color preferences added here? |
frmdstryr
force-pushed
the
3d-view-preference
branch
from
0fbcb60 to
62bf64e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a "3D View" section to the "Editor" preferences tab with new settings to set the default view projection and colors.
Screencast_20260109_211710.webm