Open
Conversation
meson.build
Outdated
| podofo = dependency('libpodofo') | ||
| if podofo.version() == 'unknown' or podofo.version() < '0.10.0' | ||
| podofo_legacy = true | ||
| elif podofo.version() < '1.0.0' |
Member
There was a problem hiding this comment.
Use the version macros provided by podofo instead.
Member
There was a problem hiding this comment.
undo whitespace changes or put then in their own commit
Member
|
Probably also makes sense to have at least one of the CI jobs have podofo in a version that's new enough. IIRC opensuse should have podofo 1.0 available. |
Author
|
Fedora has also switched |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated API usage following https://github.com/podofo/podofo/blob/master/API-MIGRATION.md. Exporting a basic pdf seems to work fine and looks identical to one exported using 0.10.x. Unfortunately I am an extreme beginner to this so I have not tested more complex cases.
Fixes #815