Feature/paypal & stripe integration by Salpertio · Pull Request #463 · hrfee/jfa-go

Salpertio · 2026-01-03T06:31:46Z

📦 Consolidated Update: Subscriptions & Store Overhaul

Note: This PR replaces and merges all previously closed billing PRs into one streamlined update.

🚀 Overview

This PR implements PayPal Subscriptions, hardens our Stripe integration, and introduces a completely redesigned Storefront.

✨ Key Features

PayPal Integration: Added full support for monthly subscriptions + webhook handling for renewals.
Store Overhaul: Redesigned the UI with a modern, centered layout and improved mobile responsiveness.
Admin Settings: New Store tab to set price and new Settings to manage API keys for PP and Stripe

🛡️ Security & Hardening (Idempotency)

Double-Credit Protection: Added LastTransactionID tracking to prevent duplicate account credits from retried webhooks.
Smart Prevention: Users with an active subscription are now blocked from starting a new one to prevent accidental double-billing.
PayPal Auto-Cleanup: Automatically cancels a user's previous subscription if they accidentally create a new one.

⚡ Stripe Enhancements

Instant Re-Enable: Ported logic to ensure accounts are automatically unbanned/re-enabled immediately after a successful Stripe payment.
Billing Sync: Unified logic to focus strictly on Monthly billing cycles.

🛠 Technical Breakdown

View detailed changes

Area	Change Description
Integrations	PayPal REST SDK + Webhook listener (`PAYMENT.SALE.COMPLETED`)
Logic	Ported "Instant Unban" logic to the Stripe provider service
Database	Added `LastTransactionID` column to enforce idempotency
UI	Updated Storefront components with modern CSS Flexbox layout

🧪 Testing Plan

PayPal: Create a test subscription and verify the user is credited.
Stripe: Pay with a disabled account and verify "Instant Unban" triggers.
Idempotency: Manually trigger the same webhook twice and ensure only 1 credit is applied.

* **Stripe Integration:** * Implemented full payment flow for paid invites using Stripe Checkout. * Added Price and Currency fields to Invites in backend and frontend. * Updated api-stripe.go to handle callbacks correctly. * Added PaymentStatus verification in api-users.go. * **UI/UX Improvements:** * Refactored Admin Create Invite form with aligned Price/Currency inputs. * Added Payment Required modal to user registration flow. * Improved Setup Wizard URL handling. * **Fixes:** * Corrected price handling (dollars vs cents). * Fixed setup wizard redirection bugs.

…json:"labels". migrations.go: Updated the ombi.NotificationPref struct literals to use explicit keys (Agent:, UserID:, etc.). jf_activity_test.go: Updated the mediabrowser.Time struct literal to use the explicit key Time:. Dockerfile: Reverted to agnostic format.

- Implemented public store page (html/store.html) matched to system theme - Added Stripe checkout integration for invite generation - Updated webhook handler to process metadata (target_email, plan) - Refactored Docker build process and added .dockerignore - Fixed various struct literals and types for build stability

- Added 'Monthly Access' plan (.00/mo) to store page with shared email input - Implemented 'invoice.payment_succeeded' webhook to extend user expiry on renewal - Configured monthly invites to have strict 30-day expiry for auto-churn - Refactored HandleWebhook to return raw events for flexibility - Added cleanup for jfa-go binary in .gitignore

Adds an admin tab to set monthly price/currency and updates the store page UI to match. Removes the one-time 'Standard' plan entirely. Fixes a type assertion panic when saving config.

- Implemented full PayPal Monthly Subscription flow with webhooks. - Implemented Stripe Monthly Subscription flow with webhooks. - Added 'Store' tab to Admin UI for configuring both providers. - Redesigned Store Page for better UI/UX. - HARDENING: Added Idempotency checks (LastTransactionID) to prevent double-credit on retries. - HARDENING: Added Auto-Cancel logic for PayPal to prevent double-billing. - HARDENING: Added Smart Prevention to block active users from re-subscribing. - HARDENING: Added Re-enable logic for both providers to instantly unban disabled users upon payment.

netlify · 2026-01-03T06:31:49Z

👷 Deploy request for jfa-go pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`bb118b0`

Salpertio · 2026-01-03T07:47:14Z

🛒 Store Configuration & Setup Guide

This update introduces dynamic pricing and a complete UI overhaul (tacking shit onto what is already functional) for the "Pay-to-Generate" feature, focusing exclusively on Monthly Subscriptions.

🎨 Store Redesign Overview

New Layout: Modern, centered design with a streamlined email input field.
Conditional Logic: The store now intelligently toggles between Stripe and PayPal buttons based on your active configuration.
Cleanup: removed standard one time payment
fixed: race condition where pay to unlock would make an invite with more than 1 use stay unlocked and swapped to pay to generate instead

🅿️ PayPal Setup Guide

⚠️ Testing Note: PayPal Sandboxing is strict. You must use two separate sets of credentials:

Business Account: Used to generate the API keys (The Seller).

Personal Account: Used to "buy" the sub in the sandbox pop-up (The Buyer).

its recommended you try the sandbox flow first to be sure it works.

1. Create your App

Log in to the PayPal Developer Dashboard.
Create an App to obtain your Client ID and Secret.

2. Create Product & Plan

You must create a specific billing plan for users to subscribe to:

Sandbox: Create Sandbox Plan
Live: Create Live Plan
Process: Create a plan (e.g., "Monthly Membership" @ $2.00).
Final Step: Copy the generated Plan ID (e.g., P-12345...).

to get there you will need to take note of as these contain the email and password creds to allow you to login

grab your business creds and head to https://sandbox.paypal.com

hit create

you will be prompted to start a new product

choose fixed note the next screen will ask you to name the plan (what the user sees on paypal)

since this isnt live you wont need to change anything besides add a number (dont go crazy with this the personal account has a limit)

after you set the payment continue to the next page skip the buttons page it drops you on

this will take you back to the subscription plans page. take note of the P-(ID) you'll need this

3. Configure jfa-go

collect your P-(ID), Client ID and Secret
Navigate to Settings > integrations > paypal and enter:

Enabled: True
Mode: Sandbox or Live
Client ID / Secret
Plan ID

💳 Stripe Setup Guide

1. Get API Keys

Log in to your Stripe Dashboard.
create a new sandbox

after creation enter the sandbox and your api keys will be presented to you when you reach the sandbox page
copy the secret key as you will need this for later.

2. Configure Webhooks

Webhooks allow Stripe to tell your app when a payment succeeds or a sub is cancelled.

Go to Webhooks and click Destination.
Endpoint URL: https://your-domain.com/stripe/webhook
Select Events: You must select these three:
- checkout.session.completed
- invoice.payment_succeeded
- customer.subscription.deleted (Crucial for revoking access on cancel)

3. Finalize jfa-go

Click Add Endpoint and reveal the Signing Secret (whsec_...).
Go to Settings > integrations > Stripe in jfa-go.
Enter your Secret Key and Webhook Secret.
Save and Restart the service.

The Store page is now live at /store.

…andlers

Salpertio · 2026-01-03T11:56:11Z

Summary

We encountered some stability issues requiring a local rollback, but we have successfully re-implemented and hardened the integration.

Status Update

Stripe (🟢 Fully Functional):

502 Errors Resolved: Implemented asynchronous email sending to prevent webhook timeouts.
Active Revocation: Verified. Manual cancellations immediately disable the user account.
Reliability: Metadata propagation fits ensuring new subscriptions carry the necessary data for automated management.
Cancel-at-Period-End: Logically covered by the same revocation handlers. (unsure about this need further testing)
stripe has a time warp function but a bit complicated for today/potentially wont allow a sub created by the user through jfa to be sped up to initiate this

PayPal (🟡 Functional / Passive Mode):

Status: Payments work correctly.
Revocation: Webhooks for "Active Revocation" (disable user) dont seem to work right now (if at all).
Fail-Safe: We rely on the Passive Expiry Daemon as a fallback. When a user cancels, they stop paying, and JFA-Go automatically disables them once their paid time runs out. This ensures no free access is given, even without live webhooks.

i can see paypal being gutted entirely though. stripe works well

UI/UX Notes

The PayPal buttons function correctly but are currently a bit clunky compared to the stripe button styling. We can refine the CSS in a future PR.

Ready for review.

hrfee · 2026-01-05T18:35:06Z

This is very big and I want to rework it to fit the style of the rest of the code so it'll take a long time.

hrfee · 2026-01-05T18:35:28Z

Also, don't worry about the review notes, those are for me.

Salpertio · 2026-01-05T21:00:48Z

Also, don't worry about the review notes, those are for me.

noted, congrats, new grad.

Salpertio added 6 commits December 27, 2025 20:08

store: add dynamic pricing config, remove standard plan

e39ba9f

Adds an admin tab to set monthly price/currency and updates the store page UI to match. Removes the one-time 'Standard' plan entirely. Fixes a type assertion panic when saving config.

github-project-automation bot added this to jfa-go Jan 3, 2026

Salpertio mentioned this pull request Jan 3, 2026

[Feature Request] Stripe / Paypal integration #368

Open

Salpertio marked this pull request as draft January 3, 2026 07:47

Fix Stripe Webhooks (Async Email + Metadata) & Restore Cancellation H…

bb118b0

…andlers

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/paypal & stripe integration#463

Feature/paypal & stripe integration#463
Salpertio wants to merge 7 commits intohrfee:mainfrom
Salpertio:feature/paypal-stripe-integration

Salpertio commented Jan 3, 2026

Uh oh!

netlify bot commented Jan 3, 2026 •

edited

Loading

Uh oh!

Salpertio commented Jan 3, 2026

Uh oh!

Salpertio commented Jan 3, 2026

Uh oh!

hrfee commented Jan 5, 2026

Uh oh!

hrfee commented Jan 5, 2026

Uh oh!

Salpertio commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Salpertio commented Jan 3, 2026

📦 Consolidated Update: Subscriptions & Store Overhaul

🚀 Overview

✨ Key Features

🛡️ Security & Hardening (Idempotency)

⚡ Stripe Enhancements

🛠 Technical Breakdown

🧪 Testing Plan

Uh oh!

netlify bot commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy request for jfa-go pending review.

Uh oh!

Salpertio commented Jan 3, 2026

🛒 Store Configuration & Setup Guide

🎨 Store Redesign Overview

🅿️ PayPal Setup Guide

1. Create your App

2. Create Product & Plan

3. Configure jfa-go

💳 Stripe Setup Guide

1. Get API Keys

2. Configure Webhooks

3. Finalize jfa-go

Uh oh!

Salpertio commented Jan 3, 2026

Summary

Status Update

UI/UX Notes

Uh oh!

hrfee commented Jan 5, 2026

Uh oh!

hrfee commented Jan 5, 2026

Uh oh!

Salpertio commented Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jan 3, 2026 •

edited

Loading