jellyseerr: delete user on account deletion#483
Open
New-tab wants to merge 1 commit intohrfee:mainfrom
Open
Conversation
Added functionality to delete a user in Jellyseerr.
👷 Deploy request for jfa-go pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a user is deleted in jfa-go, their Jellyseerr account is not removed. Ombi handles this already in
DeleteUser()inusers.go. This PR adds the same behavior for Jellyseerr.js.DeleteUsertakes the Jellyfin user ID directly, so no additionallookup is needed unlike the Ombi case.
I saw the
FIXME, but I figured if there is already an interim solution for Ombi... Apologies for the tiny PR--selfishly just trying to avoid having to build from source.Tested manually against Seerr 3.1.0 with manual deletion.