feat: improve status_format and track_format#1716
Open
mgumz wants to merge 2 commits intohrkfdn:mainfrom
Open
Conversation
this commit adds `%track_number` and `%disc_number` to the available options to format status and track.
Author
|
if there is some interest in this PR, i'll update the users.md |
This commit introduces `number_format` which controls how the
`%track_number` option in `status_format` and `track_format`
are rendered:
```toml
status_format = "%track_number. %title - %artists"
number_format = "{:>3}"
```
This will produce:
003. a sing a long - robo, the singer
Supported format strings are: {:>2}, {:>3}, {:>4}, {:>5}, {:02},
{:03}, {:04}, {:05}.
Implementation note: the picked `match` expression is much simpler
than to use a Regex (or dynstr or strfmt and their shortcomings in
the control of how the number is rendered)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
%track_numberand%disc_numberto the available options to format status and track.Describe your changes
status_formatandtrack_formatgain two additional options: the%track_numberand%disc_number.Issue ticket number and link
Checklist before requesting a review
not performance improvements, etc.)