feat: sort by added_at in albums list by default#1806
Open
brtholomy wants to merge 2 commits intohrkfdn:mainfrom
Open
feat: sort by added_at in albums list by default#1806brtholomy wants to merge 2 commits intohrkfdn:mainfrom
brtholomy wants to merge 2 commits intohrkfdn:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changes the default behavior of the Albums list in the library view to sort by date the album was saved. Old behavior was a lexical ordering, which is in my opinion not useful, and deviates from the behavior of the Tracks and Playlists tabs. (Artists list should also probably follow.)
Disclaimer: I'm a Rust noob and just guessed. But it compiles and works. Note I just removed the resorting behavior from save_album, since inserting at the 0 index does what we want.
Issue ticket number and link
#747
Checklist before requesting a review
not performance improvements, etc.)