Open
Conversation
zhou-hao
reviewed
Jun 17, 2025
...em/hsweb-system-file/src/main/java/org/hswebframework/web/file/FileServiceConfiguration.java
Outdated
Show resolved
Hide resolved
...em/hsweb-system-file/src/main/java/org/hswebframework/web/file/FileServiceConfiguration.java
Outdated
Show resolved
Hide resolved
...em/hsweb-system-file/src/main/java/org/hswebframework/web/file/FileServiceConfiguration.java
Outdated
Show resolved
Hide resolved
zhou-hao
reviewed
Jun 17, 2025
...system/hsweb-system-file/src/main/java/org/hswebframework/web/file/web/S3FileController.java
Outdated
Show resolved
Hide resolved
Author
|
重新调整了代码,走本地还是 S3 通过 "hsweb.file.storage"来控制,S3相关配置也遵循之前配置属性的命名基础上添加。控制 S3的相关配置: 单元测试成功之后我删除了accessKey和secretKey,其余问题也改掉了 |
zhou-hao
reviewed
Jun 17, 2025
...em/hsweb-system-file/src/main/java/org/hswebframework/web/file/FileServiceConfiguration.java
Outdated
Show resolved
Hide resolved
...system/hsweb-system-file/src/main/java/org/hswebframework/web/file/FileUploadProperties.java
Outdated
Show resolved
Hide resolved
.../hsweb-system-file/src/main/java/org/hswebframework/web/file/service/FileStorageService.java
Outdated
Show resolved
Hide resolved
修改error应当由Mono传递,而不是抛出异常 移除非必要Condition条件
zhou-hao
reviewed
Jun 17, 2025
.../hsweb-system-file/src/main/java/org/hswebframework/web/file/S3FileStorageConfiguration.java
Outdated
Show resolved
Hide resolved
.../hsweb-system-file/src/main/java/org/hswebframework/web/file/S3FileStorageConfiguration.java
Outdated
Show resolved
Hide resolved
.../hsweb-system-file/src/main/java/org/hswebframework/web/file/web/ReactiveFileController.java
Outdated
Show resolved
Hide resolved
.../hsweb-system-file/src/main/java/org/hswebframework/web/file/web/ReactiveFileController.java
Show resolved
Hide resolved
.../hsweb-system-file/src/main/java/org/hswebframework/web/file/web/ReactiveFileController.java
Outdated
Show resolved
Hide resolved
zhou-hao
reviewed
Jun 18, 2025
...system/hsweb-system-file/src/main/java/org/hswebframework/web/file/FileUploadProperties.java
Outdated
Show resolved
Hide resolved
...sweb-system-file/src/main/java/org/hswebframework/web/file/service/S3FileStorageService.java
Show resolved
Hide resolved
...sweb-system-file/src/main/java/org/hswebframework/web/file/service/S3FileStorageService.java
Show resolved
Hide resolved
采用buffer.asInputStream访问文件 移除冗余代码
zhou-hao
reviewed
Jun 19, 2025
...sweb-system-file/src/main/java/org/hswebframework/web/file/service/S3FileStorageService.java
Outdated
Show resolved
Hide resolved
mengnankkkk
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
切换本地和oss通过环境变了file.storage=local/s3控制
s3协议的相关配置均在S3StorageProperties类中