feat: Add full inference server response to InferenceResult#410
Open
feat: Add full inference server response to InferenceResult#410
InferenceResult#410Conversation
… `inference_example_chunked.py` generations type, and introduce two new demo files.
Collaborator
|
For proper typing, something like: |
Collaborator
Author
I am not sure it's good idea to add typing. To me the only reason we are adding the raw response is to enable users to extract stuff on top of what we already parse so we should be as flexible as possible there so I would just keep it as is. |
Collaborator
|
This is as flexible as possible as they can get any field they need. The api is a format and this dataclass covers most of the current implementations, I don't see any reason to not add it like this (and you're usually the type obsessed, surprised at the role reversal) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.