Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
xenova
reviewed
Feb 3, 2026
Collaborator
xenova
left a comment
There was a problem hiding this comment.
Very exciting PR! 🙌 Just a quick review from scanning the PR briefly.
…tion that does not check for tokenizer files or processor files if the task does not use them
Co-authored-by: Joshua Lochner <admin@xenova.com>
xenova
requested changes
Feb 19, 2026
Collaborator
xenova
left a comment
There was a problem hiding this comment.
Solid progress! Thanks 🔥
Co-authored-by: Joshua Lochner <admin@xenova.com>
…s.js into v4-cache-handler
breaks simultaneous loading
nico-martin
commented
Feb 27, 2026
xenova
approved these changes
Mar 1, 2026
Collaborator
xenova
left a comment
There was a problem hiding this comment.
Huge PR! 🔥 Thanks so much @nico-martin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved Download Progress Tracking
Problem
Transformers.js couldn't reliably track total download progress because:
Solution
New Exported Functions
get_files(): Determines required files before downloadingget_model_files()/get_tokenizer_files()/get_processor_files(): Helper functions to identify files for each componentget_file_metadata(): Fetches file metadata using Range requests without downloading full contentfromCacheboolean to identify cached filesis_cached(): Checks if all files from a model are already in cacheEnhanced Progress Tracking
readResponse()withexpectedSize: Falls back to metadata whencontent-lengthheader is missingtotal_progresscallback: Provides aggregate progress across all filesReview
One thing I am not super confident is the get_model_files function. I tried to test it with different model architectures, but maybe I missed some that load files that are not in that function. @xenova, could you smoke-test some models and write mie the models that fail?
Easiest way to do that is:
Closes #1345