feat(grpo_trainer.py): Variational Sequence-Level Soft Policy Optimization (VESPO)#5199
Draft
casinca wants to merge 4 commits intohuggingface:mainfrom
Draft
feat(grpo_trainer.py): Variational Sequence-Level Soft Policy Optimization (VESPO)#5199casinca wants to merge 4 commits intohuggingface:mainfrom
grpo_trainer.py): Variational Sequence-Level Soft Policy Optimization (VESPO)#5199casinca wants to merge 4 commits intohuggingface:mainfrom
Conversation
grpo_trainer.py): Variational Sequence-Level Soft Policy Optimization (VESPO)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
TODO
official impl: https://github.com/FloyedShen/VESPO/blob/main/recipe/vespo/code/core_algos.py
paper: https://huggingface.co/papers/2602.10693
Note:
The paper and the official implementation can have different variable names, to make things clearer:
Docstrings/comments are a mix of official impl and my writing.
Alternative options:
k_pos,lambda_pos,k_neg,lambda_negbut I could reduce with 2 tuples of 2 floats eg: lambdas (pos, neg) if it's better.w_seqalso. I can include it in metrics, but this would force me to return a tuple inget_gamma_weightsor remove@staticmethod. Not sure here what's the preference.For efficiency, the TRL VESPO implementation is slightly different than the official one. It's ~25% faster on gpu, and tested for equivalence.
Fixes #5196
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.