Move wp-cli command before 'enabled' check#685
Open
limestreet wants to merge 1 commit intohumanmade:masterfrom
Open
Move wp-cli command before 'enabled' check#685limestreet wants to merge 1 commit intohumanmade:masterfrom
limestreet wants to merge 1 commit intohumanmade:masterfrom
Conversation
Currently, when `S3_UPLOADS_AUTOENABLE` is set to `false` the `wp-cli` command doesn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when
S3_UPLOADS_AUTOENABLEis set tofalsethewp-clicommand doesn't work.Most likely the current behaviour is not intended, looking at the original code before it was moved to
init()-> #619My PR should fix that, so it is closer to initial implementation.
Thank you in advance for considering :)