Remove unused locale support from SDK #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locale/i18n support was scaffolded but never implemented - see Preview.ts:398 which explicitly passed `undefined // locale not supported yet`. Removed from: - Types (StudioMessage, SDKMessage, FieldUpdateBase, ElementAttributes, etc.) - Core modules (Preview, FieldRegistry, ContentUpdater, OverlayManager) - Attribute helpers (createPreviewAttributes, PreviewFieldOptions) - React components (HygraphPreview, HygraphPreviewNextjs) - Tests (removed locale-specific test, updated attribute test) No breaking changes - locale was never documented or functional. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
undefined // locale not supported yetcomment in Preview.ts confirming it was never functionalChanges
Removed
locale/data-hygraph-field-localefrom:StudioMessage,SDKMessage,FieldUpdateBase,ElementAttributes,RegisteredElement,PreviewEvents)Preview.ts,FieldRegistry.ts,ContentUpdater.ts,OverlayManager.ts)createPreviewAttributes,PreviewFieldOptions)HygraphPreview,HygraphPreviewNextjs)Test plan
npm run type-checkpassesnpm run testpasses (24 tests)npm run buildsucceedsNo breaking changes - locale was never documented or functional for users.
🤖 Generated with Claude Code