Skip to content

Comments

implement testing_buildBlockV1#9838

Draft
macfarla wants to merge 1 commit intohyperledger:mainfrom
macfarla:testing-buildblockv1
Draft

implement testing_buildBlockV1#9838
macfarla wants to merge 1 commit intohyperledger:mainfrom
macfarla:testing-buildblockv1

Conversation

@macfarla
Copy link
Contributor

PR description

related to #9832 which also introduces GenericBlockCreator
RpcMethod.java — Added TESTING_BUILD_BLOCK_V1("testing_buildBlockV1")

Refs a proposed JSON-RPC method, it introduces a new namespace specifically for testing and a new method testing_buildBlockV1 - there is a go-ethereum PR and OpenRPC specs, etc.
ethereum/execution-apis#710
ethereum/execution-apis#747
ethereum/go-ethereum#33656

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant