refactor: move isRevertReasonEnabled into DataStorageConfiguration#9858
Draft
kkaur01 wants to merge 3 commits intohyperledger:mainfrom
Draft
refactor: move isRevertReasonEnabled into DataStorageConfiguration#9858kkaur01 wants to merge 3 commits intohyperledger:mainfrom
kkaur01 wants to merge 3 commits intohyperledger:mainfrom
Conversation
Closes hyperledger#7597 - Add `revertReasonEnabled` field to `DataStorageConfiguration` (alongside existing storage concerns like `receiptCompactionEnabled`) - Move `--revert-reason-enabled` CLI option from `BesuCommand` into `DataStorageOptions` so it is serialised/deserialised with the rest of the data-storage group automatically - Replace the two standalone boolean params `enableRevertReason` and `isParallelTxProcessingEnabled` in `MainnetProtocolSpecs`, `MainnetProtocolSpecFactory`, `ProtocolScheduleBuilder`, `MainnetProtocolSchedule` and all consensus schedule builders with a single `DataStorageConfiguration` object - Remove now-redundant `isRevertReasonEnabled` / `isParallelTxProcessingEnabled` fields and setters from `BesuControllerBuilder`; all controller builders pass `dataStorageConfiguration` directly - Fix `ProcessBesuNodeRunner` duplicate-flag bug: `--revert-reason-enabled` was being added both by `DataStorageOptions.getCLIOptions()` and explicitly; removed the explicit addition Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: kkaur01 <kanchan.kaur@consensys.net>
kkaur01
force-pushed
the
refactor-revert-reason-to-data-storage-config
branch
from
045b4a2 to
f0509bc
Compare
…ation Replace old boolean isRevertReasonEnabled param with DataStorageConfiguration in all MainnetProtocolSchedule.fromConfig() calls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: kkaur01 <kanchan.kaur@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Replace the two standalone boolean parameters (isRevertReasonEnabled,
isParallelTxProcessingEnabled) threaded through 8+ layers of the call stack with a single DataStorageConfiguration object, which is already the home of related storage concerns (receiptCompactionEnabled, etc.).
The --revert-reason-enabled CLI flag moves from BesuCommand into DataStorageOptions. No behaviour change.
Fixed Issue(s)
fixes #7597
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests