gradle: regenerate blocks.bin when code has changed#9864
Open
macfarla wants to merge 2 commits intohyperledger:mainfrom
Open
gradle: regenerate blocks.bin when code has changed#9864macfarla wants to merge 2 commits intohyperledger:mainfrom
macfarla wants to merge 2 commits intohyperledger:mainfrom
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a Gradle build issue where the blocks.bin test resource file wasn't being regenerated when source code changed, causing trace spec tests to fail with stale or missing data. The fix replaces the onlyIf condition with proper Gradle input/output declarations to enable incremental build tracking.
Changes:
- Removed
onlyIfconditions that prevented task re-execution whenblocks.binalready existed - Added proper input/output declarations to
importTestBlocksandexportTestBlockstasks for incremental build support - Moved input/output declarations from wrapper task
generateTestBlockchainto the actual execution tasks
Comments suppressed due to low confidence (1)
ethereum/api/build.gradle:137
- The
importTestBlockstask declaresoutputs.dir(dataPath)but the downstreamexportTestBlockstask usesinputs.dir(dataPath). However,exportTestBlockslikely only needs the database files created indataPath, not the entire directory. Consider whetheroutputs.files()with specific database file paths would be more precise, or add a comment explaining why the entire directory is needed as output.
inputs.dir(srcFiles)
inputs.files(configurations.testResourceGeneration)
outputs.dir(dataPath)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixes the issue where sometimes all the trace spec tests fail because blocks.bin doesn't exist or something has changed.
to verify this:
check out main
rm ethereum/api/build/resources/test/org/hyperledger/besu/ethereum/api/jsonrpc/trace/chain-data/blocks.bin
touch ethereum/api/build/resources/test/org/hyperledger/besu/ethereum/api/jsonrpc/trace/chain-data/blocks.bin
./gradlew :ethereum:api:test --tests "org.hyperledger.besu.ethereum.api.jsonrpc.bonsai.TraceJsonRpcHttpBySpecTest"
tests fail
checkout this pr;
./gradlew :ethereum:api:test --tests "org.hyperledger.besu.ethereum.api.jsonrpc.bonsai.TraceJsonRpcHttpBySpecTest"
tests pass
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests