Skip to content

Reverse slide direction#14043

Open
QuarkVortexx wants to merge 3 commits intohyprwm:mainfrom
QuarkVortexx:reverse-slide-dir
Open

Reverse slide direction#14043
QuarkVortexx wants to merge 3 commits intohyprwm:mainfrom
QuarkVortexx:reverse-slide-dir

Conversation

@QuarkVortexx
Copy link
Copy Markdown

Hello,

This is my first contribution to the project, so hopefully everything is in check! Overall, I'm very new to the OSS space. I read the PR guidelines and tried to follow them appropriately.

Describe your PR, what does it fix/add?

Previously, the slide animation direction was fixed. This meant that with slidevert animation, the "first" workspace always felt to be at the top of the stack. Alternatively, in regular slide, the "first" workspace always felt as if it was the most left workspace.

For me, this created confusion with the slidevert animation, as mentally for me, the first workspace is the lowest in the stack. So I decided to create a setting for reversing the slide direction to allow for new options. I also thought that this was a great addition to the vast configurability of Hyprland.

So instead of simply requesting for the feature, I thought it's better to create it and share it with others by including a PR.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I'm new to the project, so my understanding of the project code base may not be the best. By my understanding, the feature should not break compatibility, nor did I find any bugs during my testing.

Is it ready for merging, or does it need work?

The feature should be ready for merging.

@github-actions
Copy link
Copy Markdown

Hello and thank you for making a PR to Hyprland!

Please check the PR Guidelines and make sure your PR follows them.
It will make the entire review process faster. :)

If your code can be tested, please always add tests. See more here.

beep boop, I'm just a bot. A real human will review your PR soon.

@Kommynct
Copy link
Copy Markdown

Can't you already do this by passing a -1?

@QuarkVortexx
Copy link
Copy Markdown
Author

Can't you already do this by passing a -1?

Oh right, this was a great find. I assume you mean, that using movement percentage (https://wiki.hypr.land/Configuring/Animations/#extras), and set it to -100, you're able to reverse the direction? I didn't realize this before.

However, after testing, it seems like this doesn't work with gestures. I'll rework my commits based on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants