Open
Conversation
|
Hello and thank you for making a PR to Hyprland! Please check the PR Guidelines and make sure your PR follows them. If your code can be tested, please always add tests. See more here. beep boop, I'm just a bot. A real human will review your PR soon. |
barrettruth
force-pushed
the
input/live-pinch-cursor-zoom
branch
from
689bbe9 to
fbdd9b0
Compare
vaxerski
reviewed
Apr 12, 2026
barrettruth
force-pushed
the
input/live-pinch-cursor-zoom
branch
from
fbdd9b0 to
753f4f8
Compare
vaxerski
reviewed
Apr 15, 2026
barrettruth
force-pushed
the
input/live-pinch-cursor-zoom
branch
from
753f4f8 to
5e3763b
Compare
Contributor
Author
|
done, thanks for your patience - i know that you're being inundated with prs this was interesting to explore and also a feature i think is really valuable. hopefully there are minimal bugs with it in the future... (lol) will continue to help out on hyprland! |
Member
|
you good it's my job |
Member
|
some tests are failing |
barrettruth
force-pushed
the
input/live-pinch-cursor-zoom
branch
from
5e3763b to
13203fc
Compare
Contributor
Author
|
fixed sorry for delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Adds a live pinch mode for
cursorZoom. This is the typical continual "zoom" gesturebehavior one expects in windows/macos.
As of this PR
cursorZoomonly supports toggle/mult-style behavior. This patch adds a continual zoom mode according to the pinch scale, keeping the zoom anchored to the initial cursor pos. I found this to most similarly imitate macos/windows zoom.Lastly, I augmented tests by restoring the cursor position after the new gesture block because this was leaking state into the new tests that I added.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
livename of the zoom mode in the gesture config. Perhaps something moreintuitive would be better.
Is it ready for merging, or does it need work?
r4r.