Skip to content

element/image: error when image exceeds max resolution#40

Merged
vaxerski merged 1 commit intohyprwm:mainfrom
noisesfromspace:hyprpaper-compat
Feb 5, 2026
Merged

element/image: error when image exceeds max resolution#40
vaxerski merged 1 commit intohyprwm:mainfrom
noisesfromspace:hyprpaper-compat

Conversation

@noisesfromspace
Copy link
Copy Markdown
Contributor

@noisesfromspace noisesfromspace commented Jan 28, 2026

After updating hyprpaper to 0.8.1 my background stopped showing, but the program would run without any errors. I download full resolution art scans from artsandculture.google.com resulting in 135mb 22413x15124 images, just because I can.

In the pre 0.8 version something probably downscaled it as the GL_MAX_TEXTURE_SIZE is way, way below this resolution. Just in case more people do silly things like me it would be great to have an error message.

[..]
DEBUG ]: DRM syncobj timeline support: yes
DEBUG ]: Found 1 output(s)
DEBUG ]: wayland: configure layer with 2560x1440
ERR ]: Image: failed loading, image dimensions 22413x15124 exceed max texture size 16384
DEBUG ]: layer: got fractional scale: 100.0%

I have never touched a c++ project so this was mostly written by Claude. Let me know if this is the wrong place / way / project etc.

Comment thread src/renderer/gl/OpenGL.hpp Outdated
@noisesfromspace noisesfromspace force-pushed the hyprpaper-compat branch 5 times, most recently from 830d9fd to 59814f3 Compare January 28, 2026 16:17
Comment thread src/renderer/gl/OpenGL.cpp Outdated
Comment thread src/element/image/Image.cpp Outdated
@noisesfromspace noisesfromspace marked this pull request as draft January 29, 2026 15:22
@noisesfromspace noisesfromspace marked this pull request as ready for review February 4, 2026 18:48
Copy link
Copy Markdown
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaxerski vaxerski merged commit 37d9217 into hyprwm:main Feb 5, 2026
2 checks passed
@noisesfromspace noisesfromspace deleted the hyprpaper-compat branch February 5, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants