feat/fix: support .yaml extension for the config file.#183
Open
aloysb wants to merge 2 commits intohywax:mainfrom
Open
feat/fix: support .yaml extension for the config file.#183aloysb wants to merge 2 commits intohywax:mainfrom
aloysb wants to merge 2 commits intohywax:mainfrom
Conversation
Collaborator
|
👋 @aloysb 💖 Thanks for opening this pull request! Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hywax
After a little bit of pain setting mafl today I thought I would propose this PR.
I took me a little bit of digging to find out that I named my config
config.yamlinstead ofconfig.yml.Since
.yamlis the official extension for yaml file, we should probably support it :)Goal
Support
.yamlextension (as well as.yml) for the config.yamlis the official extension, but since all the docs points to.ymlI don't think we should enforce it as the default or only option. But supportingconfig.yamlseems important.Besides, the unraid is currently pointing to a
config.yamlwhich would result in an error!How to test
There isn't a test suite as far as I can tell (happy to set one up for you) so I didn't put any tests - only manually checked the code.
To do, run this branch locally with a
config.yamland ensure it works as expected!Thanks for the good work, I love this project.