fix(config): implement cached config fallback on load failure#189
Open
hdkiller wants to merge 7 commits intohywax:mainfrom
Open
fix(config): implement cached config fallback on load failure#189hdkiller wants to merge 7 commits intohywax:mainfrom
hdkiller wants to merge 7 commits intohywax:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a caching mechanism to the configuration loader to improve stability.
Problem:
Currently, if the configuration file update fails or is momentarily inaccessible (e.g., during a write operation), the application throws a 500 error immediately after retries fail.
Solution:
cachedConfigvariable insrc/server/utils/config.ts.loadConfigfails (even after retries), it now checks for a cached version.