-
Notifications
You must be signed in to change notification settings - Fork 4
Manifest v3 update #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… being set correctly
Summary of ChangesHello @erohrs2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the stability and functionality of the extension, primarily by resolving several identified bugs. It addresses issues related to script injection on GitHub pages, improves the detection of tracked issues within pull request lists, and refines the parsing of diff statistics. These changes aim to ensure the extension operates more reliably and accurately across GitHub's interface, building upon previous Manifest v3 updates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request delivers several valuable fixes that improve the Chrome extension's functionality and robustness, particularly for interactions with GitHub. The updates to the manifest for better URL matching, the refined data extraction logic for PR comments and diff stats, and the correction of the race condition in the background script are all excellent changes. The code is now more resilient to changes in GitHub's front-end and more reliable in its data handling. I have one minor suggestion to maintain code style consistency.
This PR primarily addresses the AI comments made in the previous PR to main from this branch.
Several bugs are fixed in this PR, including:
All other changes were fixes to incorrect code that have little to no impact on the extension.