Skip to content

Conversation

@erohrs2
Copy link
Contributor

@erohrs2 erohrs2 commented Jan 3, 2026

This PR primarily addresses the AI comments made in the previous PR to main from this branch.

Several bugs are fixed in this PR, including:

  • GitHub issues and PR urls not being injected (In the manifest)
  • TrackedIssues in PR lists not being detected
  • Diff stats for a Pull Request not being trimmed correctly

All other changes were fixes to incorrect code that have little to no impact on the extension.

@gemini-code-assist
Copy link

Summary of Changes

Hello @erohrs2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability and functionality of the extension, primarily by resolving several identified bugs. It addresses issues related to script injection on GitHub pages, improves the detection of tracked issues within pull request lists, and refines the parsing of diff statistics. These changes aim to ensure the extension operates more reliably and accurately across GitHub's interface, building upon previous Manifest v3 updates.

Highlights

  • Fixed GitHub URL injection: The manifest.json file has been updated to correctly inject scripts into GitHub issue and pull request URLs, addressing previous injection failures.
  • Improved TrackedIssues detection: The logic for detecting 'TrackedIssues' in PR lists has been refined to correctly identify the task progress count using the 'TRACKED-ISSUES-PROGRESS' tag and its 'dataset.total' attribute.
  • Corrected Diff stats parsing: The parsing of diff statistics for pull requests now correctly extracts and trims the added and removed lines, ensuring accurate display of changes.
  • General code quality improvements: Several minor code fixes and cleanups have been applied across various JavaScript files, enhancing overall code correctness with minimal impact on extension functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request delivers several valuable fixes that improve the Chrome extension's functionality and robustness, particularly for interactions with GitHub. The updates to the manifest for better URL matching, the refined data extraction logic for PR comments and diff stats, and the correction of the race condition in the background script are all excellent changes. The code is now more resilient to changes in GitHub's front-end and more reliable in its data handling. I have one minor suggestion to maintain code style consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants