Conversation
…ng device id, os, app version.
…to gmap-pending-fixes
…stination instruction.
…ransit and walk legs.
Replaced retired jdk version with amazon corretto
…o match dev branch
| * using the trip start time and the monitored days. | ||
| * (Itinerary existence is not being checked, assuming that clients prevent monitoring days when a trip doesn't exist.) | ||
| */ | ||
| public static ZonedDateTime findEarliestTargetDate(MonitoredTrip trip, ZonedDateTime fromDateTime) { |
There was a problem hiding this comment.
This method conflicts with the one in MonitoredTrip. I think the one in MonitoredTrip should be used instead because it was recently fixed by #362.
| /** | ||
| * Advance the target date/time until a day is found when the trip is active. | ||
| */ | ||
| private static ZonedDateTime findNextMonitoredDay(MonitoredTrip trip, ZonedDateTime startingDay) { |
There was a problem hiding this comment.
Use the method from MonitoredTrip and remove this one.
| /** | ||
| * Whether to advance to the next monitored day. | ||
| */ | ||
| public boolean shouldAdvanceToNextDay() { |
There was a problem hiding this comment.
shouldAdvanceToNextDay appears to be only used in tests, so this method and relevant tests can be removed.
| computeTargetZonedDateTime(); | ||
| resetJourneyState(); | ||
|
|
||
| // reset journey state departure/arrival times |
There was a problem hiding this comment.
Remove duplicate statement.
| if ( | ||
| isBusLeg(busLeg) && routeId != null && | ||
| hasNotCanceledNotificationForRoute(travelerPosition.trackedJourney, routeId) | ||
| hasNotCanceled |
There was a problem hiding this comment.
Fix tabs.
There was a problem hiding this comment.
Revert the changes that introduce garbled characters.
| Arguments.of(TUESDAY_20200609.withHour(8), TUESDAY_20200609.withHour(9), false), | ||
| // Trip snoozed at 8:00am on Tuesday, June 9, 2020, should unsnooze at 12:00am (midnight) on | ||
| // Wednesday, June 10, 2020, but it is too early for the trip to be analyzed again. | ||
| Arguments.of(TUESDAY_20200609.withHour(8), wednesday, true), |
There was a problem hiding this comment.
Remove, these are duplicate.
| UsRideGwinnettNotifyBusOperator.IS_TEST = true; | ||
|
|
There was a problem hiding this comment.
Remove duplicate statement.
3 participants
Checklist
devbefore they can be merged tomaster)Description
Please explain the changes you made here and, if not immediately obvious from the code, how they resolve any referenced issues. Be sure to include all issues being resolved and any special configuration settings that are need for the software to run properly with these changes. If merging to master, please also list the PRs that are to be included.