Open
Conversation
br648
reviewed
Jan 6, 2026
| return new ItineraryFromLegMatcher(itinerary, legResponses).process(); | ||
| } | ||
|
|
||
| private Map<String, Leg> getLegResponsesNonThreaded(List<Leg> transitLegs) { |
Contributor
There was a problem hiding this comment.
Add a comment as to why this might be used instead of the threaded version.
# Conflicts: # src/main/java/org/opentripplanner/middleware/otp/response/Leg.java # src/test/java/org/opentripplanner/middleware/tripmonitor/jobs/CheckMonitoredTripTest.java
daniel-heppner-ibigroup
approved these changes
Jan 30, 2026
Contributor
daniel-heppner-ibigroup
left a comment
daniel-heppner-ibigroup
left a comment
There was a problem hiding this comment.
Very unfamiliar with the codebase, but it looks good from my scroll through.
daniel-heppner-ibigroup
assigned
binh-dam-ibigroup and unassigned
daniel-heppner-ibigroup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR changes the approach for checking itinerary existence. Instead of sending
planqueries to OTP, we send insteadlegqueries based on expected leg id, and we attempt to reconstruct the original itinerary with the updated legs. If there is sufficient time for transfers between two consecutive transit legs, the reconstructed itinerary is deemed valid.Many tests using
planqueries are rewritten to uselegqueries, however the functionality to sendplanqueries remains/is not deleted yet. (so is the mock OTP test feature)There are no UI changes. The following should still work with the latest OTP-RR code: