Document the synchronous Complete convention - #4908
Open
bernardnormier wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
bernardnormier
added
the
documentation
bernardnormier
requested review from
pepone
and removed request for
InsertCreativityHere
August 31, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dismissed-audit pattern for the decision recorded in #965: IceRPC completes pipe readers and writers with
Complete, neverCompleteAsync, and treatsCompleteas a fast, non-blocking call. The pattern also records why this works (noComplete()with unflushed bytes; decorators and transports don't wait inComplete) and how a decorator that must emit a trailer, such as the compressor's, fits in: a few synchronous bytes that fail fast on a completed decoratee, with no asynchronous finalization step.The review of #4840 showed this decision was not captured anywhere an AI reviewer would find it.
What's Changed entry
None — documentation for AI coding agents.
🤖 Generated with Claude Code