Fixed the boundary check in PatchSidesetGenerator

[joshuahansel]

The boundary-exists check in PatchSidesetGenerator was broken due to using the wrong ID type, which didn't respect the invalid ID check.

Closes #32724

[moosebuild]

Job Documentation, step Docs: sync website on 5aa0b26 wanted to post the following:

View the site here

This comment will be updated on new commits.

[moosebuild]

Job Coverage, step Generate coverage on 5aa0b26 wanted to post the following:

Framework coverage

	d7c4bd	#33187 5aa0b2
	Total	Total	+/-	New
Rate	85.99%	85.99%	-0.00%	100.00%
Hits	136168	136168	-	20
Misses	22185	22189	+4	0

Diff coverage report

Full coverage report

Modules coverage

Heat transfer

	d7c4bd	#33187 5aa0b2
	Total	Total	+/-	New
Rate	89.10%	89.11%	+0.01%	100.00%
Hits	4758	4756	-2	4
Misses	582	581	-1	0

Diff coverage report

Full coverage report

Reactor

	d7c4bd	#33187 5aa0b2
	Total	Total	+/-	New
Rate	94.03%	94.03%	-	100.00%
Hits	8428	8428	-	1
Misses	535	535	-	0

Diff coverage report

Full coverage report

Full coverage reports

Reports

• framework
• chemical_reactions
• combined
• contact
• electromagnetics
• external_petsc_solver
• fluid_properties
• fsi
• functional_expansion_tools
• geochemistry
• heat_transfer
• level_set
• misc
• navier_stokes
• optimization
• peridynamics
• phase_field
• porous_flow
• ray_tracing
• rdg
• reactor
• scalar_transport
• solid_mechanics
• solid_properties
• stochastic_tools
• subchannel
• thermal_hydraulics
• xfem

This comment will be updated on new commits.

[joshuahansel]

This will proceed after #33190

[joshuahansel]

This depends on #33190 - I'll rebase and mark ready when that one is merged.

[moosebuild]

Job Test, step Results summary on 5aa0b26 wanted to post the following:

Framework test summary

Compared against d7c4bde in job civet.inl.gov/job/3938647.

No change

Modules test summary

Compared against d7c4bde in job civet.inl.gov/job/3938647.

Removed tests

Test	Time (s)	Memory (MB)
heat_transfer/test:generate_radiation_patch.generate_radiation_patch_linear	0.66	105.19
heat_transfer/test:generate_radiation_patch.generate_radiation_patch	0.65	111.52
heat_transfer/test:generate_radiation_patch.generate_radiation_patch_grid	0.64	109.35
heat_transfer/test:generate_radiation_patch.generate_radiation_patch_centroid	0.62	114.28
heat_transfer/test:generate_radiation_patch.generate_radiation_patch_centroid_error	0.54	27.71
heat_transfer/test:generate_radiation_patch.generate_radiation_patch_grid_2D	0.53	101.05
heat_transfer/test:generate_radiation_patch.generate_radiation_patch_grid_2D_overpart	0.50	87.14

Added tests

Test	Time (s)	Memory (MB)
heat_transfer/test:meshgenerators/patch_sideset_generator.patch_sideset_generator	0.70	80.37
heat_transfer/test:meshgenerators/patch_sideset_generator.patch_sideset_generator_grid	0.69	83.28
heat_transfer/test:meshgenerators/patch_sideset_generator.patch_sideset_generator_linear	0.69	105.99
heat_transfer/test:meshgenerators/patch_sideset_generator.patch_sideset_generator_centroid	0.66	105.36
heat_transfer/test:meshgenerators/patch_sideset_generator.patch_sideset_generator_centroid_error	0.59	83.24
heat_transfer/test:meshgenerators/patch_sideset_generator.patch_sideset_generator_grid_2D_overpart	0.57	65.55
heat_transfer/test:radiation_transfer_action.nonexistent_boundary	0.54	91.15
heat_transfer/test:meshgenerators/patch_sideset_generator.patch_sideset_generator_grid_2D	0.54	111.73

[joshuahansel]

Nevermind my previous comments - I plan to close #33190 in favor of this one. This one is ready.