Merged
Conversation
API change: The /api/roms endpoint now requires the pluralized form 'platform_ids' to match the new multi-value parameter format.
- Add shared find_platform_by_name() method to RommBot class - Remove duplicate find_platform_by_name() from search.py cog - Update firmware(), random(), search() commands to reuse fetched platform data instead of re-fetching 2-3 times per command - Update scan.py to use shared method instead of inline logic This eliminates 6+ redundant API calls across the codebase and centralizes platform lookup logic for easier maintenance.
Send both platform_id and platform_ids in API queries to support both old and new RomM versions: - Old RomM: uses platform_id, ignores platform_ids - New RomM: uses platform_ids, ignores platform_id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.