feat(core) array builtin parity + indexed-scalar inputs and ownership fixes#327
Draft
Guikingone wants to merge 1 commit into
Draft
feat(core) array builtin parity + indexed-scalar inputs and ownership fixes#327Guikingone wants to merge 1 commit into
Guikingone wants to merge 1 commit into
Conversation
…rship fixes 15 PHP array builtins, dual-arch (ARM64/x86_64), tested and GC-clean: array_is_list, array_key_first/last, array_replace, array_replace_recursive, array_diff_assoc, array_intersect_assoc, array_merge_recursive, array_walk_recursive, array_find/any/all, array_udiff/uintersect, array_multisort. Correctness fixes: - array_merge_recursive: persist combined-list string values (fixes a use-after-free when the temporary scalar wrappers are released). - Hash-based builtins persist string values into results instead of incref-sharing (fixes a latent use-after-free when an input is freed before the result). Scalar indexed-array inputs for the 5 hash-based builtins via the new __rt_array_to_hash converter; result key/value widen to Mixed for heterogeneous inputs. Validated on macOS ARM64, Linux x86_64, and Linux ARM64.
Guikingone
changed the title
Member
|
Hi @Guikingone, I'm currently landing the new IR-based backend path on main. Feel free to mark this PR as ready for review when you're ready. I'll take care of aligning it with the new backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
15 PHP array builtins, dual-arch (ARM64/x86_64), tested and GC-clean: array_is_list, array_key_first/last, array_replace, array_replace_recursive, array_diff_assoc, array_intersect_assoc, array_merge_recursive, array_walk_recursive, array_find/any/all, array_udiff/uintersect, array_multisort.
Correctness fixes:
Scalar indexed-array inputs for the 5 hash-based builtins via the new __rt_array_to_hash converter; result key/value widen to Mixed for heterogeneous inputs.
Validated on macOS ARM64, Linux x86_64, and Linux ARM64.