Open
Conversation
Specify that requestFullscreen sends the model into an in-line full-screen mode, Added a non-normative note about the _kind_ of behavior that some (all?) of the spatial browsers currently seem to agree on as an interpretation for `requestFullscreen()` (I think the listed issue was meant to be 34 rather than a dupe of 31) fixes #34
zachernuk
assigned
mkeblx,
cabanier and
LaszloGombos and unassigned
mkeblx,
cabanier and
LaszloGombos
Collaborator
Author
|
Apologies, I set assignees instead of reviewers! |
Member
|
I don't quite follow what you are trying to describe. Maybe we can discuss this during a weekly call? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify that requestFullscreen sends the model into an in-line full-screen mode,
Added a non-normative note about the kind of behavior that some (all?) of the spatial browsers currently seem to agree on as an interpretation for
requestFullscreen()(I think the listed issue was meant to be 34 rather than a dupe of 31)
fixes #34
@toji are there more general obligations we should try to meet to describe / agree on a spatial browser's fullscreen? It's definitely convenient that we all seem to agree so far!
Preview | Diff