refactoring provonerdf and uncomment test_experiment#105
Open
sanuann wants to merge 5 commits intoincf-nidash:masterfrom
Open
refactoring provonerdf and uncomment test_experiment#105sanuann wants to merge 5 commits intoincf-nidash:masterfrom
sanuann wants to merge 5 commits intoincf-nidash:masterfrom
Conversation
satra
reviewed
Aug 23, 2018
nidm/core/provone.py
Outdated
|
|
||
| PROVONE_REC_CLS.update(PROV_REC_CLS) | ||
|
|
||
| # PROV_REC_CLS.update({ |
satra
reviewed
Aug 23, 2018
nidm/core/provone.py
Outdated
| PROV_COMMUNICATION: Communication, | ||
| PROV_DERIVATION: Derivation, | ||
| PROV_GENERATION: Generation, | ||
| # PROV_ATTRIBUTION: Attribution, |
Collaborator
There was a problem hiding this comment.
since git tracks code, better to remove than comment.
satra
reviewed
Aug 23, 2018
| # very simple test, just checking if main doesnt give any error | ||
| # def test_main(): | ||
| # main(sys.argv[1:]) | ||
| def test_main(): |
Collaborator
There was a problem hiding this comment.
why is this PR touching the test_experiment file?
Author
There was a problem hiding this comment.
I uncommented the tests there, which I had previously commented out.
Collaborator
added 4 commits
August 23, 2018 11:12
merge down PyNIDM master
merge down master to provone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.