IWF-101: Use different structures for WorkflowStateOptions#283
Merged
steven-rg-harrison merged 19 commits intomainfrom Dec 19, 2024
Merged
IWF-101: Use different structures for WorkflowStateOptions#283steven-rg-harrison merged 19 commits intomainfrom
steven-rg-harrison merged 19 commits intomainfrom
Conversation
src/test/java/io/iworkflow/integ/stateapifail/StateFailProceedToRecoverBasic.java
Outdated
Show resolved
Hide resolved
src/test/java/io/iworkflow/integ/stateapifail/StateFailProceedToRecoverNoWaitUntil.java
Outdated
Show resolved
Hide resolved
added 5 commits
December 17, 2024 17:51
src/main/java/io/iworkflow/core/WorkflowStateOptionsExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/io/iworkflow/core/mapper/StateMovementMapper.java
Outdated
Show resolved
Hide resolved
Contributor
longquanzheng
left a comment
longquanzheng
left a comment
There was a problem hiding this comment.
more minor comments and found a bug in the previous code(not from you). Otherwise lgtm (great job, this is quite some refactoring)!
src/main/java/io/iworkflow/core/mapper/StateMovementMapper.java
Outdated
Show resolved
Hide resolved
Contributor
longquanzheng
left a comment
longquanzheng
left a comment
There was a problem hiding this comment.
looks great. I promise this is the last run like this 😂
src/main/java/io/iworkflow/core/mapper/StateMovementMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/io/iworkflow/core/mapper/StateMovementMapper.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issue
Closes #<issue_number>