Skip to content

fix: do not require init/step when compiling to JSON, #1584#1812

Open
yazaldefilimone wants to merge 7 commits intoinformalsystems:mainfrom
yazaldefilimone:fix/compile-no-init-step
Open

fix: do not require init/step when compiling to JSON, #1584#1812
yazaldefilimone wants to merge 7 commits intoinformalsystems:mainfrom
yazaldefilimone:fix/compile-no-init-step

Conversation

@yazaldefilimone
Copy link
Copy Markdown

@yazaldefilimone yazaldefilimone commented Nov 15, 2025

  • I have read and I understand the Note on AI-assisted contributions
  • Changes manually tested locally and confirmed to work as described
    (including screenshots is helpful)
  • Tests added for any new code
  • Documentation added for any new functionality
  • Entries added to the respective CHANGELOG.md for any new functionality

const targetIsTla = args.target === 'tlaplus'

// check which core definitions are missing
let flattenRequires: string | null = null
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this missingFlattenDefs? I find the requires confusing in this context

Copy link
Copy Markdown
Author

@yazaldefilimone yazaldefilimone Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bugarela done

yazaldefilimone and others added 4 commits December 12, 2025 15:49
Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>
Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>
Co-authored-by: Gabriela Moreira <gabrielamoreira05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants