fix: improve confluent kafka's global variable access #834
+25
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CagriYonca
commented
Jan 12, 2026
CagriYonca
commented
- Close the consumer span when the poll request returns None.
- Improve the consumer_token and consumer_span access.
Signed-off-by: Cagri Yonca <[email protected]>
GSVarsha
reviewed
Jan 12, 2026
| context.detach(consumer_token) | ||
| consumer_token = None | ||
| token = consumer_token.get(None) | ||
| if token is not None: |
Contributor
There was a problem hiding this comment.
Suggested change
| if token is not None: | |
| if token: |
Contributor
Author
There was a problem hiding this comment.
PEP8 document refers using is not None for checking None conditions:
|
GSVarsha
reviewed
Jan 12, 2026
| create_span("poll", res.topic(), res.headers()) | ||
| else: | ||
| span = consumer_span.get(None) | ||
| if span is not None: |
Contributor
There was a problem hiding this comment.
Suggested change
| if span is not None: | |
| if span: |
Contributor
Author
There was a problem hiding this comment.
PEP8 document refers using is not None for checking None conditions:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.