Skip to content

fix(aggregate): release lock on failure#166

Merged
XOlegator merged 3 commits into
masterfrom
fix/aggregate-locking
Jun 7, 2026
Merged

fix(aggregate): release lock on failure#166
XOlegator merged 3 commits into
masterfrom
fix/aggregate-locking

Conversation

@XOlegator

Copy link
Copy Markdown
Contributor

What changed

  • replaced stale lock-file TTL handling with file locking via flock in aggregate
  • guaranteed lock release in finally so failed aggregate runs no longer block later runs
  • made register-crontab emit an explicit PHP binary invocation with --no-interaction
  • updated the lock notification wording and deployment docs

Why

Aggregate could leave var/aggregate.lock behind after any unhandled failure. That caused later cron runs to report a false concurrent execution state until the TTL expired.

Impact

  • aggregate no longer gets stuck behind stale lock files after runtime failures
  • cron examples and generated crontab entries now pin the intended PHP binary

Validation

  • php -l src/Command/AggregateCommand.php
  • php -l src/Command/InitCommand.php
  • php bin/console lint:twig templates/lock_notification.html.twig
  • php bin/console doctrine:migrations:migrate --no-interaction
  • php bin/console aggregate --no-interaction

@XOlegator XOlegator changed the title [codex] fix aggregate locking after failed runs fix(aggregate): release lock on failure Jun 7, 2026
@XOlegator XOlegator marked this pull request as ready for review June 7, 2026 09:32
@XOlegator XOlegator merged commit 0fbb82d into master Jun 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant