Skip to content

Add improved checks and behavior for memory with invalid values #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkorbel1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add improved checks and behavior for memory with invalid values #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/src/models/memory_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,15 @@ class MemoryModel extends Memory {
for (final wrPort in wrPorts) {
if (!wrPort.en.previousValue!.isValid && !storage.isEmpty) {
// storage doesnt have access to `en`, so check ourselves
storage.invalidWrite();
if (wrPort.addr.previousValue!.isValid) {
// we only need to clear that address
storage.setData(
wrPort.addr.previousValue!, LogicValue.ofInt(0, dataWidth));
storage.onInvalidWrite();
} else {
storage.invalidWrite();
}

return;
}

Expand Down
10 changes: 8 additions & 2 deletions lib/src/models/sparse_memory_storage.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import 'package:collection/collection.dart';
import 'package:rohd/rohd.dart';
import 'package:rohd_hcl/src/exceptions.dart';
import 'package:rohd_hcl/src/utils.dart';
import 'package:rohd_vf/rohd_vf.dart';

/// A storage for memory models.
abstract class MemoryStorage {
Expand All @@ -28,8 +29,13 @@ abstract class MemoryStorage {

/// Default behavior for [onInvalidWrite].
static void _defaultOnInvalidWrite() {
// ignore: avoid_print
print('WARNING: Memory was cleared by invalid write!');
if (Test.instance != null) {
Test.instance?.logger
.warning('WARNING: Memory was cleared by invalid write!');
} else {
// ignore: avoid_print
print('WARNING: Memory was cleared by invalid write!');
}
}

/// A function called if a read is made to an address that has no data.
Expand Down
Loading