feat: oci aware chart rendering#16
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds OCI-awareness to the chart rendering path in chartvalidator so Helm templating works for both classic chart repos and OCI registries.
Changes:
- Build the
helm templateinvocation differently for OCI repos by omitting--repoand using a fully-qualified OCI chart reference. - Add small helpers (
isOCIRepo,resolveChartReference) to centralize OCI detection/reference construction. - Extend tests to cover OCI rendering and update the expected non-OCI command string ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| chartvalidator/checker/engine_chart_rendering.go | Conditionally omits --repo for OCI and resolves OCI chart refs as oci://.../<chartName>. |
| chartvalidator/checker/engine_chart_rendering_test.go | Updates baseline expected command order and adds an OCI-specific render test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| func resolveChartReference(chart ChartRenderParams) string { | ||
| if isOCIRepo(chart.RepoURL) { | ||
| return fmt.Sprintf("%s/%s", strings.TrimSuffix(chart.RepoURL, "/"), chart.ChartName) |
Comment on lines
+58
to
+65
| testChart.RepoURL = "oci://europe-west4-docker.pkg.dev/wallet-dev-462809/interledger-helm-charts" | ||
| engine.inputChan <- testChart | ||
|
|
||
| result := <-engine.resultChan | ||
| assertChartFieldsMatch(t, testChart, result.Chart) | ||
|
|
||
| // OCI charts should be templated using the full OCI chart reference, not --repo. | ||
| expectedCommand := "helm template oci://europe-west4-docker.pkg.dev/wallet-dev-462809/interledger-helm-charts/test-chart --release-name test-chart -f values.yaml -f override.yaml --version 1.0.0 --include-crds --kube-version 1.33.0 --api-versions something --api-versions something-else" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.