Simplify and strengthen namespace-level storage.#520
Open
toddjonker wants to merge 1 commit intoion-fusion:mainfrom
Open
Simplify and strengthen namespace-level storage.#520toddjonker wants to merge 1 commit intoion-fusion:mainfrom
toddjonker wants to merge 1 commit intoion-fusion:mainfrom
Conversation
This does two things: * Stop pointless lazy allocation that left dangerous edge cases while adding work to every mutation of a namespace variable. * Synchronizes all access to the store, so behavior under contention is better behaved. At the very least, we won't corrupt this data structure.
| public final Object lookup(int address) | ||
| { | ||
| return myValues.get(address); | ||
| synchronized (myDefinedValues) |
Contributor
There was a problem hiding this comment.
Do these reads need to be synchronized? Are there cases where lookups will be happening in contention with their address being set? At least to my intuition, the writes would need to be synchronized to ensure addresses are allocated correctly, but once we reach this code path it means an address has been allocated and thus should be safe to read without contention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does two things:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.