fix(web): don't throw if vibrate is not supported#11
Open
supermar1010 wants to merge 1 commit intoionic-team:mainfrom
Open
fix(web): don't throw if vibrate is not supported#11supermar1010 wants to merge 1 commit intoionic-team:mainfrom
supermar1010 wants to merge 1 commit intoionic-team:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
README.mdstates "On devices that don't have Taptic Engine or Vibrator, the API calls will resolve without performing any action.".Right now on web this plugin throws an exception if the vibrate api is not supported, this seems to be out of line with the
README.mdthus I propose changing the web code to no throw anymore. (Related issue)