Allow setting the color for controls in the browser toolbar#1315
Open
JanMisker wants to merge 6 commits intoionic-team:mainfrom
Open
Allow setting the color for controls in the browser toolbar#1315JanMisker wants to merge 6 commits intoionic-team:mainfrom
JanMisker wants to merge 6 commits intoionic-team:mainfrom
Conversation
Enable setting both the toolbar tint as well as the controls tint color.
|
Would love to see this one merged and published 🙏 |
|
I would love to see this merged in and available. 🤓 👍 |
Member
|
Thanks for opening this PR 🙏 As part of our backlog maintenance effort, we’re reviewing older pull requests for compatibility with the current branch structure and latest releases. Details: https://ionic.io/blog/keeping-capacitors-backlog-healthy This PR will need to be rebased against the latest main branch and updated to resolve merge conflicts. If we don’t see updates within 7 days, we’ll close it to keep the queue focused — but it can always be resubmitted once updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements setting a color for the controls in the browser overlay, as mentioned in #911 .
I only made changes for iOS, not sure if something is needed for Android.
So now next to the
toolbarColoryou can also set acontrolsColorin the params forBrowser.open, e.g.