feat(@capacitor/screen-orientation): Orientation 'landscape' lock uses current held landscape

[codepip55]

Fixes #2039

[brian-weasner]

@codepip55 This has conflicts now that the code in #2022 has been merged.

[brian-weasner]

Comment: Merge conflicts accidentally overwrote changes that I made as a part of #2022

[codepip55]

I think I've fixed everything now, let me know if I missed something :)

[brian-weasner]

@IT-MikeS I know you just helped get #2022 merged, is there a way we can get this in soon as well so that they can roll out in the same releases for cap v5 and cap v6?

[codepip55]

Is there a timeline for when we can expect this to be merged?

[shiv19]

The linting warnings from CI are unrelated to the changes made in this PR.

[ericmulder]

Any news on this pull request?

[codepip55]

Any updates on this PR?

[jansgescheit]

Any updates on this PR @brian-weasner @IT-MikeS ? it's been lying around for a long time now and many people are waiting for it

[ericmulder]

Hi @brian-weasner and @IT-MikeS, would it be possible to merge this?

[brian-weasner]

Thanks for the @, as this fell off of my radar after my bugfix ticket got merged.

@ericmulder , @jansgescheit,
NOTE: I'm not on the capacitor team so I don't have merge privileges.

This issue just came about around the same time I was fixing #2022. Because of that I've been communicating with this ticket to be sure that it's changes wouldn't overwrite the changes I made.

Since #2022 has been merged into 5.x branch and subsequently into Capacitor v5 and v6, although there is no mention of it in the CHANGELOG.md in either v5 or v6 branches, there is a workaround that can be used. Simply get the current orientation, check to see if it contains the word "landscape" and if so lock it to that orientation.

The following code has not been tested:

const currentOrientation = await ScreenOrientation.orientation();
if (currentOrientation.includes('landscape')) {
    await ScreenOrientation.lock({orientation: currentOrientation]);
}

I still agree that this should be merged because this brings about nice changes. @IT-MikeS Is there anything blocking this from getting merged?