feat(radio): make radio buttons full width for ionic theme#30393
Closed
OS-martacarlos wants to merge 1 commit intonextfrom
Closed
feat(radio): make radio buttons full width for ionic theme#30393OS-martacarlos wants to merge 1 commit intonextfrom
OS-martacarlos wants to merge 1 commit intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
closing this PR as it's not necessary, the same look can be achieved using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ion-radios would only use the necessary widthWhat is the new behavior?
For the ionic theme:
ion-radionow take up the full width, following the new design specifications (here)ion-radioandion-radio-grouptest snapshots were updated accordinglyDoes this introduce a breaking change?