feat(toolbar): added separated variables for size of slots in Toolbar#30973
Closed
os-davidlourenco wants to merge 1 commit intonextfrom
Closed
feat(toolbar): added separated variables for size of slots in Toolbar#30973os-davidlourenco wants to merge 1 commit intonextfrom
os-davidlourenco wants to merge 1 commit intonextfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-davidlourenco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
For the Ionic theme, the slots on each side of the toolbar have the same size given by the same variable
What is the new behavior?
Each slot has the size given by a specific variable for that slot that is initialised with the value of the previous variable
Does this introduce a breaking change?
Other information