fix(input-otp): prevent deletion when readonly is true#30983
Open
KanhaiyaPandey wants to merge 1 commit intoionic-team:mainfrom
Open
fix(input-otp): prevent deletion when readonly is true#30983KanhaiyaPandey wants to merge 1 commit intoionic-team:mainfrom
KanhaiyaPandey wants to merge 1 commit intoionic-team:mainfrom
Conversation
|
@KanhaiyaPandey is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30913
Description
When
ion-input-otphas thereadonlyprop set, typing is correctly blocked but users are still able to delete characters using the Backspace or Delete keys.This PR ensures that all keyboard interactions that modify the value are prevented when
readonlyis true.Changes
readonlyinside keydown handlerHow to Test
readonlytoion-input-otpBehavior now matches expected readonly semantics.