-
Notifications
You must be signed in to change notification settings - Fork 3k
[NEWTON] support dextrah environments with warp rendering #4421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev/newton
Are you sure you want to change the base?
[NEWTON] support dextrah environments with warp rendering #4421
Conversation
Greptile Summary
Important Files Changed
Confidence score: 3/5
Sequence DiagramsequenceDiagram
participant User
participant InteractiveScene
participant TiledCamera
participant NewtonWarpRenderer
participant NewtonManager
participant ObservationManager
User->>InteractiveScene: __init__(cfg)
InteractiveScene->>InteractiveScene: _add_entities_from_cfg()
InteractiveScene->>TiledCamera: __init__(cfg)
TiledCamera->>TiledCamera: _initialize_impl()
TiledCamera->>NewtonWarpRenderer: __init__(renderer_cfg)
TiledCamera->>NewtonWarpRenderer: initialize()
InteractiveScene->>InteractiveScene: clone_environments()
InteractiveScene->>NewtonManager: newton_replicate()
User->>InteractiveScene: reset(env_ids)
InteractiveScene->>TiledCamera: reset(env_ids)
TiledCamera->>NewtonWarpRenderer: reset()
User->>ObservationManager: compute_group()
ObservationManager->>TiledCamera: update()
TiledCamera->>TiledCamera: _update_buffers_impl()
TiledCamera->>TiledCamera: _update_poses()
TiledCamera->>NewtonWarpRenderer: render(pos, quat, intrinsics)
NewtonWarpRenderer-->>TiledCamera: output_buffer
TiledCamera->>TiledCamera: wp.to_torch(output_buffer)
TiledCamera-->>ObservationManager: camera.data.output
ObservationManager-->>User: observations
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (3)
-
source/isaaclab/isaaclab/sim/_impl/newton_manager.py, line 378 (link)style: The parameter
prune_noncollidingis still in the function signature but is no longer usedNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
-
source/isaaclab_newton/isaaclab_newton/assets/rigid_object/rigid_object_data.py, line 719-728 (link)logic: This creates a quaternion array but the property should return linear velocity. The wrong kernel
split_transform_array_to_quaternion_arrayis being used on pose data instead of splitting velocity data. -
source/isaaclab_newton/isaaclab_newton/assets/rigid_object/rigid_object_data.py, line 337-351 (link)logic: This property claims to return center of mass velocity but uses
_body_com_pose_w.timestampfor cache invalidation and applies transform operations instead of returning the velocity binding_sim_bind_body_com_vel_w.
41 files reviewed, 32 comments
source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/adr_curriculum.py
Outdated
Show resolved
Hide resolved
...sks/manager_based/manipulation/dexsuite/config/kuka_allegro/dexsuite_kuka_allegro_env_cfg.py
Show resolved
Hide resolved
...lab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/config/kuka_allegro/__init__.py
Show resolved
Hide resolved
source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/mdp/observations.py
Show resolved
Hide resolved
source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/mdp/observations.py
Show resolved
Hide resolved
source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/mdp/rewards.py
Show resolved
Hide resolved
source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/dexsuite_env_cfg.py
Show resolved
Hide resolved
source/isaaclab_tasks/isaaclab_tasks/manager_based/manipulation/dexsuite/dexsuite_env_cfg.py
Show resolved
Hide resolved
c4e2cbb to
890de08
Compare
|
don't merge this one, there is big asset issue, this pr is used for collaboration |
Description
Introducing dexsuite with support for warp rendering, single camera version implemented.
merging this PR requires #4416 merged first
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there