Open
Conversation
* MESH-0000: Add Len() method to caches and log cache lengths in controllers * MESH-0000: Add Len() method to caches and log cache lengths in controllers (#978) Co-authored-by: pchaand <punakshi_chaand@gmail.com> * MESH-0000: Add Len() method to mock caches in virtualservice tests --------- Co-authored-by: pchaand <punakshi_chaand@gmail.com>
…outing VS,DR (#940) * enhance logging for VirtualService deletion handling * MESH-5873: add logging and skip updates for custom VS/DR in reconciliation process * enhance virtual service generation with error handling and logging for missing hosts and routes * refactor virtual service deletion logic to consolidate routing resource cleanup * update virtual service deletion test to not return an error for non-existent services * add annotations to existing DestinationRules in routing tests * remove redundant old virtual service retrieval logic in routing controller * MESH-5873: refactor VS/DR naming with common suffix constants for consistency * MESH-5873: Fix parameter passed to deleteVirtualService function * MESH-5873: Remove unused destination rule deletion logic and constant * MESH-5873: Enhance error handling in deleteVSRoutingResources function * MESH-5873: Remove unused context initialization in virtualservice routing test --------- Co-authored-by: pchaand <punakshi_chaand@gmail.com>
shriramsharma
approved these changes
Jul 9, 2025
fixed dr pinning issue
…LB idle timeout setting Signed-off-by: pchaand <punakshi_chaand@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 75.87% 75.67% -0.21%
==========================================
Files 73 73
Lines 12686 12787 +101
==========================================
+ Hits 9626 9676 +50
- Misses 2537 2585 +48
- Partials 523 526 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review this repository's contribution guidelines.
Description
What does this change do and why?
[Link to related ISSUE]
Thank you!