4410: Fixes after test

.env

@@ -5,6 +5,7 @@
 ###> aakb/itkdev-docker configuration ###
 COMPOSE_PROJECT_NAME=itstyr
 COMPOSE_DOMAIN=itstyr.local.itkdev.dk
+ITKDEV_TEMPLATE=symfony-6
 ###< aakb/itkdev-docker configuration ###
 
 ###> symfony/framework-bundle ###

.github/workflows/changelog.yaml

@@ -2,7 +2,7 @@
 # github/workflows/changelog.yaml in
 # https://github.com/itk-dev/devops_itkdev-docker if need be.
 
-### ## Changelog
+### ### Changelog
 ###
 ### Checks that changelog has been updated
 

.github/workflows/composer.yaml

@@ -2,11 +2,11 @@
 # github/workflows/composer.yaml in
 # https://github.com/itk-dev/devops_itkdev-docker if need be.
 
-### ## Composer
+### ### Composer
 ###
 ### Validates composer.json and checks that it's normalized.
 ###
-### ### Assumptions
+### #### Assumptions
 ###
 ### 1. A docker compose service named `phpfpm` can be run and `composer` can be
 ###    run inside the `phpfpm` service.
@@ -31,6 +31,9 @@ env:
 on:
   pull_request:
   push:
+    branches:
+      - main
+      - develop
 
 jobs:
   composer-validate:

.github/workflows/javascript.yaml

@@ -0,0 +1,36 @@
+# Do not edit this file! Make a pull request on changing
+# github/workflows/symfony/javascript.yaml in
+# https://github.com/itk-dev/devops_itkdev-docker if need be.
+
+### ### Symfony JavaScript (and TypeScript)
+###
+### Validates JavaScript files.
+###
+### #### Assumptions
+###
+### 1. A docker compose service named `prettier` for running
+###    [Prettier](https://prettier.io/) exists.
+
+name: JavaScript
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+      - develop
+
+jobs:
+  javascript-lint:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - run: |
+          docker network create frontend
+
+      - run: |
+          docker compose run --rm prettier 'assets/**/*.js' --check

.github/workflows/markdown.yaml

@@ -2,19 +2,30 @@
 # github/workflows/markdown.yaml in
 # https://github.com/itk-dev/devops_itkdev-docker if need be.
 
-### ## Markdown
+### ### Markdown
 ###
-### Uses [itkdev/markdownlint](https://hub.docker.com/r/itkdev/markdownlint) to
-### link all Markdown files (`**/*.md`) in the project.
+### Lints Markdown files (`**/*.md`) in the project.
 ###
-### [markdownlint-cli configuration ### files](https://github.com/igorshubovych/markdownlint-cli?tab=readme-ov-file#configuration),
-### `.markdownlint.jsonc` and `.markdownlintignore` control what is actually linted and how.
+### [markdownlint-cli configuration
+### files](https://github.com/igorshubovych/markdownlint-cli?tab=readme-ov-file#configuration),
+### `.markdownlint.jsonc` and `.markdownlintignore`, control what is actually
+### linted and how.
+###
+### #### Assumptions
+###
+### 1. A docker compose service named `markdownlint` for running `markdownlint`
+###    (from
+###    [markdownlint-cli](https://github.com/igorshubovych/markdownlint-cli))
+###    exists.
 
 name: Markdown
 
 on:
   pull_request:
   push:
+    branches:
+      - main
+      - develop
 
 jobs:
   markdown-lint:
@@ -26,4 +37,7 @@ jobs:
         uses: actions/checkout@v4
 
       - run: |
-          docker run --rm --volume "$PWD":/md itkdev/markdownlint '**/*.md'
+          docker network create frontend
+
+      - run: |
+          docker compose run --rm markdownlint markdownlint '**/*.md'

.github/workflows/php.yaml

@@ -0,0 +1,56 @@
+# Do not edit this file! Make a pull request on changing
+# github/workflows/symfony/php.yaml in
+# https://github.com/itk-dev/devops_itkdev-docker if need be.
+
+### ### Symfony PHP
+###
+### Checks that PHP code adheres to the [Symfony coding
+### standards](https://symfony.com/doc/current/contributing/code/standards.html).
+###
+### #### Assumptions
+###
+### 1. A docker compose service named `phpfpm` can be run and `composer` can be
+###    run inside the `phpfpm` service. 2.
+###    [friendsofphp/php-cs-fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer)
+###    is a dev requirement in `composer.json`:
+###
+###    ``` shell
+###    docker compose run --rm phpfpm composer require --dev friendsofphp/php-cs-fixer
+###    ```
+###
+###    Clean up and check code by running
+###
+###    ``` shell
+###    docker compose run --rm phpfpm vendor/bin/php-cs-fixer fix
+###    docker compose run --rm phpfpm vendor/bin/php-cs-fixer fix --dry-run --diff
+###    ```
+###
+### > [!NOTE] The template adds `.php-cs-fixer.dist.php` as [a configuration
+### > file for PHP CS
+### > Fixer](https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/config.rst)
+### > and this makes it possible to override the actual configuration used in a
+### > project by adding a more important configuration file, `.php-cs-fixer.php`.
+
+name: Symfony PHP
+
+env:
+  COMPOSE_USER: root
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+      - develop
+
+jobs:
+  coding-standards:
+    name: PHP - Check Coding Standards
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - run: |
+          docker network create frontend
+          docker compose run --rm phpfpm composer install
+          # https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/usage.rst#the-check-command
+          docker compose run --rm phpfpm vendor/bin/php-cs-fixer fix --dry-run --diff

.github/workflows/styles.yaml

@@ -0,0 +1,36 @@
+# Do not edit this file! Make a pull request on changing
+# github/workflows/symfony/styles.yaml in
+# https://github.com/itk-dev/devops_itkdev-docker if need be.
+
+### ### Symfony Styles (CSS and SCSS)
+###
+### Validates styles files.
+###
+### #### Assumptions
+###
+### 1. A docker compose service named `prettier` for running
+###    [Prettier](https://prettier.io/) exists.
+
+name: Styles
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+      - develop
+
+jobs:
+  styles-lint:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - run: |
+          docker network create frontend
+
+      - run: |
+          docker compose run --rm prettier 'assets/**/*.{css,scss}' --check

.github/workflows/twig.yaml

@@ -0,0 +1,48 @@
+# Do not edit this file! Make a pull request on changing
+# github/workflows/twig.yaml in
+# https://github.com/itk-dev/devops_itkdev-docker if need be.
+
+### ### Twig
+###
+### Validates Twig files
+###
+### #### Assumptions
+###
+### 1. A docker compose service named `phpfpm` can be run and `composer` can be
+###    run inside the `phpfpm` service.
+### 2. [vincentlanglet/twig-cs-fixer](https://github.com/VincentLanglet/Twig-CS-Fixer)
+###    is a dev requirement in `composer.json`:
+###
+###    ``` shell
+###    docker compose run --rm phpfpm composer require --dev vincentlanglet/twig-cs-fixer
+###    ```
+###
+### 3. A [Configuration
+###    file](https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/docs/configuration.md#configuration-file)
+###    in the root of the project defines which files to check and rules to use.
+
+name: Twig
+
+env:
+  COMPOSE_USER: root
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+      - develop
+
+jobs:
+  twig-lint:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - run: |
+          docker network create frontend
+          docker compose run --rm phpfpm composer install
+          docker compose run --rm phpfpm vendor/bin/twig-cs-fixer lint

.markdownlint.jsonc

@@ -1,3 +1,6 @@
+// This file is copied from config/markdown/.markdownlint.jsonc in https://github.com/itk-dev/devops_itkdev-docker.
+// Feel free to edit the file, but consider making a pull request if you find a general issue with the file.
+
 // markdownlint-cli configuration file (cf. https://github.com/igorshubovych/markdownlint-cli?tab=readme-ov-file#configuration)
 {
   "default": true,

.markdownlintignore

@@ -1,8 +1,16 @@
+# This file is copied from config/markdown/.markdownlintignore in https://github.com/itk-dev/devops_itkdev-docker.
+# Feel free to edit the file, but consider making a pull request if you find a general issue with the file.
+
 # https://github.com/igorshubovych/markdownlint-cli?tab=readme-ov-file#ignoring-files
 vendor/
 node_modules/
 LICENSE.md
 # Drupal
 web/*.md
 web/core/
+web/libraries/
 web/*/contrib/
+
+# Project ignores
+mappings.md
+templates/svg/font-awesome-info.md

.php-cs-fixer.dist.php

@@ -1,16 +1,23 @@
 <?php
+// This file is copied from config/symfony/php/.php-cs-fixer.dist.php in https://github.com/itk-dev/devops_itkdev-docker.
+// Feel free to edit the file, but consider making a pull request if you find a general issue with the file.
 
-$finder = (new PhpCsFixer\Finder())
-    ->in(__DIR__)
-    ->exclude('var')
-;
+// https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/config.rst
 
-return (new PhpCsFixer\Config())
-    ->setRules([
-        '@Symfony' => true,
-        'phpdoc_align' => false,
-        // Don't remove @param that define collection and array generics (yes they should have complete comments, but).
-        'no_superfluous_phpdoc_tags' => false,
-    ])
-    ->setFinder($finder)
-;
+$finder = new PhpCsFixer\Finder();
+// Check all files …
+$finder->in(__DIR__);
+// … that are not ignored by VCS
+$finder->ignoreVCSIgnored(true);
+
+$config = new PhpCsFixer\Config();
+$config->setFinder($finder);
+
+$config->setRules([
+  '@Symfony' => true,
+  'phpdoc_align' => false,
+  // Don't remove @param that define collection and array generics (yes they should have complete comments, but).
+  'no_superfluous_phpdoc_tags' => false,
+]);
+
+return $config;

.twig-cs-fixer.dist.php

@@ -0,0 +1,16 @@
+<?php
+// This file is copied from config/symfony/twig/.twig-cs-fixer.dist.php in https://github.com/itk-dev/devops_itkdev-docker.
+// Feel free to edit the file, but consider making a pull request if you find a general issue with the file.
+
+// https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/docs/configuration.md#configuration-file
+
+$finder = new TwigCsFixer\File\Finder();
+// Check all files …
+$finder->in(__DIR__);
+// … that are not ignored by VCS
+$finder->ignoreVCSIgnored(true);
+
+$config = new TwigCsFixer\Config\Config();
+$config->setFinder($finder);
+
+return $config;

CHANGELOG.md

@@ -8,6 +8,9 @@ See [keep a changelog] for information about writing changes to this log.
 
 ## [Unreleased]
 
+* [PR-33](https://github.com/itk-dev/sysstatus/pull/33)
+  * Inlined actions
+  * Cleaned up report views
 * [PR-32](https://github.com/itk-dev/sysstatus/pull/32)
   3644: Cleaned up template and controller
 * [PR-31](https://github.com/itk-dev/sysstatus/pull/31)