fix: handle service messages and unsupported message types #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add UnsupportedMessageTypeError to handle MessageService, MessageEmpty, etc. - Update GetSingleMessage to return specific error instead of generic 'invalid message' - Add error handling in download iterator to skip system messages gracefully - System messages include 'user joined', 'message pinned', etc. which aren't downloadable
- Add DeletedMessageError type for better error handling - Show yellow warning in console when skipping system/deleted messages - Both log to file and display to user during download
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the --skip-same implementation when attempting downloads of unsupported message types.