Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
============================================
+ Coverage 95.33% 95.65% +0.32%
+ Complexity 753 695 -58
============================================
Files 16 16
Lines 1759 1866 +107
============================================
+ Hits 1677 1785 +108
+ Misses 82 81 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Looks like upstream PHP 8.1 security support is ending in three months. Though, Debian 11 bullseye, which ships PHP 7.4, will continue to be supported for one more year. And while I would typically follow Debian, the improvements in PHP 8 do sound quite tempting.
There was a problem hiding this comment.
I tend to be relax on PHP version but it seems we are stuck in PHP 7.4 for a while now when major version of recent lib (monolog, doctrine, symfony, etc.) are pushing to 8.2 instead.
And to be fair, Rector is helping so much to handle version upgrade.
There was a problem hiding this comment.
We can probably drop the options resolver and just use PHP 8 named arguments in a constructor. But that should go to later PR.
| private const FIXTURE_DIRECTORY = __DIR__ . '/../../tests/fixtures/content'; | ||
| private const MATCHING_ERROR_COMMENT = 'TODO: Rector was unable to evaluate this Graby config.'; | ||
| private const IGNORE_COMMENT = 'Rector: do not add mock client'; | ||
| private BetterNodeFinder $betterNodeFinder; |
There was a problem hiding this comment.
I assume these changes are made by rector but have no bearing on ability to run the code. It would be easier to review if they were split into a separate commit.
There was a problem hiding this comment.
Yeah it was done by rector as maintenance folder is part of the config.
2 participants
No description provided.