feat: add external_labels config that does not overwrite metric labels#729
Open
FUSAKLA wants to merge 1 commit intojacksontj:masterfrom
Open
feat: add external_labels config that does not overwrite metric labels#729FUSAKLA wants to merge 1 commit intojacksontj:masterfrom
FUSAKLA wants to merge 1 commit intojacksontj:masterfrom
Conversation
Signed-off-by: Martin Chodur <martin.chodur@firma.seznam.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to address #727
the
external_labelsconfig name is probably not self-explanatory, maybe something likeadditional_labels?This is more of a POC
What it does:
Otherwise, it keeps the selector because it could match the label values of metrics where the value is possibly unknown by promxy
There is still at least one edge case...
Consider server group with
external_labels: {"cluster": "cluster1"}and Prometheis in it, having metricsup{cluster="cluster2"}andup{cluster="cluster3"}.Then if you run query
up{cluster="cluster1"}you get a response matching both the metrics because the selectorcluster="cluster1"got removed, and now it matches both the metrics :/This is at least confusing 😖
WDYT?