Add flag prometheus.web.config.file#744
Open
hienvanhuynh wants to merge 1 commit intojacksontj:masterfrom
Open
Add flag prometheus.web.config.file#744hienvanhuynh wants to merge 1 commit intojacksontj:masterfrom
hienvanhuynh wants to merge 1 commit intojacksontj:masterfrom
Conversation
Current web.config.file does not use the same format as prometheus web.config.file. It is also lacking http headers and basic authentication handling. This is to add prometheus.web.config.file flag that works just like web.config.file of prometheus. It allows configuring http headers, while keeping the old flag web.config.file for backward compatibility.
Contributor
Author
|
@jacksontj what do you think? This is useful when we want to set http headers to the response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current web.config.file does not use the
same format as prometheus web.config.file.
It is also lacking http headers and basic
authentication handling.
This is to add prometheus.web.config.file
flag that works just like web.config.file
of prometheus. It allows configuring http
headers, while keeping the old flag
web.config.file for backward compatibility.