Skip to content

Add SigV4 Support#746

Merged
jacksontj merged 2 commits intojacksontj:masterfrom
lewinkedrs:master
Mar 3, 2026
Merged

Add SigV4 Support#746
jacksontj merged 2 commits intojacksontj:masterfrom
lewinkedrs:master

Conversation

@lewinkedrs
Copy link
Copy Markdown
Contributor

Issue #745 . This pull requests adds SigV4 support to Promxy for Querying of Amazon Managed Prometheus workspaces. All tests are passing and I confirmed i can query 2 AMP workspaces in a federated query with Promski.

{
    "status": "success",
    "data": {
        "resultType": "vector",
        "result": [
            {
                "metric": {
                    "__name__": "up",
                    "workspace": "workspace-1",
                    ...
                },
                "value": [1771607847.645, "1"]
            },
            {
                "metric": {
                    "__name__": "up",
                    "workspace": "workspace-2",
                    ...
                },
                "value": [1771607847.645, "1"]
            }
        ]
    }
}

Package Test Summary

Package Status Duration
pkg/alertbackfill ✅ PASS cached
pkg/config ✅ PASS cached
pkg/logging ✅ PASS cached
pkg/middleware ✅ PASS cached
pkg/promclient ✅ PASS cached
pkg/promhttputil ✅ PASS cached
pkg/proxyquerier ✅ PASS no test files
pkg/proxystorage ✅ PASS cached
pkg/remote ✅ PASS cached
pkg/server ✅ PASS cached
pkg/servergroup ✅ PASS cached
test ✅ PASS cached

@lewinkedrs lewinkedrs mentioned this pull request Feb 23, 2026
@lewinkedrs
Copy link
Copy Markdown
Contributor Author

Any feedback on this?

@jacksontj
Copy link
Copy Markdown
Owner

Thanks for the contribution! I have kicked off the CI run; assuming this looks good we can merge this in!

@pedroapero
Copy link
Copy Markdown
Contributor

pedroapero commented Mar 2, 2026

We are using aws-sigv4-proxy sidecar containers but your way is definitely better (might require more code maintenance though).

@lewinkedrs
Copy link
Copy Markdown
Contributor Author

I pushed a change to not require aws provider chain to be set for test to pass. I think we should pass the CI build now.

@jacksontj jacksontj merged commit 6f546ac into jacksontj:master Mar 3, 2026
1 check passed
This was referenced Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants