Merged
Conversation
Closed
Contributor
Author
|
Any feedback on this? |
Owner
|
Thanks for the contribution! I have kicked off the CI run; assuming this looks good we can merge this in! |
Contributor
|
We are using aws-sigv4-proxy sidecar containers but your way is definitely better (might require more code maintenance though). |
Contributor
Author
|
I pushed a change to not require aws provider chain to be set for test to pass. I think we should pass the CI build now. |
This was referenced Mar 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #745 . This pull requests adds SigV4 support to Promxy for Querying of Amazon Managed Prometheus workspaces. All tests are passing and I confirmed i can query 2 AMP workspaces in a federated query with Promski.
Package Test Summary
pkg/alertbackfillpkg/configpkg/loggingpkg/middlewarepkg/promclientpkg/promhttputilpkg/proxyquerierpkg/proxystoragepkg/remotepkg/serverpkg/servergrouptest